[vyatta-svn] Vyatta OFR build: Changes to 'master'

[Rick Balocca]

More ol' email
----- Original Message ----- 
From: "Stig Thormodsrud" <stig at vyatta.com>
To: <svn at vyatta.com>
Sent: Wednesday, June 27, 2007 4:39 PM
Subject: Re: [vyatta-svn] Vyatta OFR build: Changes to 'master'


>I wondering what others think about commented out code (not trying to pick
> on Marat's commit as there is commented out code all over xorp).  At
> previous companies we were not allowed to commit commented out code into
> production code as it often only serves to confuse, make code less 
> readable
> and cause conflicts in merges.
>
> I'm a bit stunned by the amount of commented out code in xorp.  Is this a
> practice that should be discouraged?  Thoughts?
>
> stig
>
>
>>  cli/Makefile.am |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> New commits:
>> commit 294d025c6606db5d10cd98f5264500ea3a8c4f82
>> Author: Marat Nepomnyashy <marat at vyatta.com>
>> Date:   Wed Jun 27 16:30:04 2007 -0700
>>
>>     Commented out NetAddr/IP.pm as it has been added to the bootstrap.
>>
>> http://suva.vyatta.com/git/?p=ofr.git;a=commitdiff;h=294d025c6606db5d10cd9
>> 8f5264500ea3a8c4f82
>> _______________________________________________
>> svn mailing list
>> svn at mailman.vyatta.com
>> http://mailman.vyatta.com/mailman/listinfo/svn
>
> _______________________________________________
> svn mailing list
> svn at mailman.vyatta.com
> http://mailman.vyatta.com/mailman/listinfo/svn
>